Skip to content

Bug Fix: use iloc to index pd.Series#877

Merged
jeongyoonlee merged 1 commit into
uber:masterfrom
bekojuniranjan:master
Feb 20, 2026
Merged

Bug Fix: use iloc to index pd.Series#877
jeongyoonlee merged 1 commit into
uber:masterfrom
bekojuniranjan:master

Conversation

@bekojuniranjan
Copy link
Copy Markdown
Contributor

Proposed changes

There was a key error in indexing pandas series in scatter_plot_summary_holdout. It is a simple issue, but it terminates the execution. And, it is solved using the iloc operator of pandas.

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 13, 2026

CLA assistant check
All committers have signed the CLA.

@jeongyoonlee
Copy link
Copy Markdown
Collaborator

Hi @bekojuniranjan. Can you sign the CLA so that we can accept your PR?

@bekojuniranjan
Copy link
Copy Markdown
Contributor Author

Hi @bekojuniranjan. Can you sign the CLA so that we can accept your PR?

I don't realise I have to sign the CLA. Now, it's done.

@jeongyoonlee jeongyoonlee self-requested a review February 20, 2026 19:34
Copy link
Copy Markdown
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeongyoonlee jeongyoonlee merged commit 4f0b31b into uber:master Feb 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants