chore: bump sourceCompatibility from 1.8 to 11 (fleet floor alignment)#687
Merged
bjagg merged 1 commit intouPortal-Project:masterfrom May 1, 2026
Merged
Conversation
CLAUDE.md says the workspace fleet floor is Java 11. NotificationPortlet's build.gradle still pinned sourceCompatibility = 1.8, which is below the floor and below the CI matrix (which already runs on Java 11 only). The pin is causing concrete pain: Gradle resolves dependencies looking for Java 8 class-file variants, and modern artifacts (guava 32+, jsonpath 3+, jackson recent patch lines) only ship Java 11+ variants. Several Renovate PRs that should be straightforward bumps fail with 'No matching variant ... compatible with Java 8' errors. Once sourceCompatibility lifts to 11, those resolve naturally. Changes: - build.gradle: sourceCompatibility = 1.8 -> 11. Notes: targetCompatibility is not pinned separately; Gradle defaults it to sourceCompatibility, so the bytecode target moves to 11 too. The CI matrix already pins Java 11 (per .github/workflows/CI.yml), so this is just aligning the pin with what the build actually runs.
2 tasks
ChristianMurphy
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
sourceCompatibilityinbuild.gradlefrom1.8to11, matching the workspace fleet floor (perCLAUDE.md).Why
The CI matrix already runs on Java 11 only (see
.github/workflows/CI.yml). ThesourceCompatibility = 1.8pin was just a stale relic, but it had a concrete cost: Gradle resolves dependencies looking for Java 8 class-file variants, and modern artifact majors don't publish those anymore.Three of the four currently-failing Renovate PRs surface this:
sourceCompatibility = 1.8Gradle reports 'No matching variant ... compatible with Java 8'Once this PR lands, those three should pass naturally. (#685 jsonpath v3 still fails — it requires Java 17; it'll be capped via a separate
renovate.jsonPR.)Changes
build.gradle:sourceCompatibility = 1.8→sourceCompatibility = 11.targetCompatibilityis not pinned separately; Gradle defaults it tosourceCompatibility, so the bytecode target moves to 11 too.Test plan
./gradlew clean build -x test— green