fix: update UUID validation to support versions 1-8, nil, max, and all#2647
Open
PleBea wants to merge 5 commits intotypestack:developfrom
Open
fix: update UUID validation to support versions 1-8, nil, max, and all#2647PleBea wants to merge 5 commits intotypestack:developfrom
PleBea wants to merge 5 commits intotypestack:developfrom
Conversation
|
Maybe #2648 can also be fixed with this PR? Since it's the same validator that requires an update |
Author
Yes, that's correct. This PR now specifically addresses issue #2648 as well. I've made a small adjustment/tweak to the relevant code (the validator) to ensure it correctly fixes #2648. Once this PR is merged, we can close that issue. |
Setitch
reviewed
Dec 30, 2025
Setitch
reviewed
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the
IsUUIDtests to align with the updated JSDoc, which specifies support for all UUID versions (1-8, nil, max, all).Previously, the tests primarily covered versions 3, 4, and 5. I have added test cases to verify that the
IsUUIDdecorator correctly validates all UUID specifications supported by the underlyingvalidator.jslibrary, including versions 1, 2, 6, 7, 8, nil, and max.Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesFixes
fixes #2581
fixed #2648