Fix building of statically linked binaries + MSVC workflow#225
Conversation
|
Looks like Apple does not support statically linked binaries: https://developer.apple.com/library/archive/qa/qa1118/_index.html |
a677a10 to
189bf36
Compare
|
If there are too many ifs and buts maybe just remove BUILD_STATIC? |
cb9b3b9 to
239bf41
Compare
|
Where is the fun in that? I like a challenge and I am learning a lot of new things too. |
80550b6 to
6fc3d72
Compare
|
Everything is building successfully and without warnings (as far as I could see in the logs).
I will continue after the holidays - Happy Easter holidays. |
69db2c9 to
6c8d905
Compare
|
Great work and nice catch with |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Steffen Pankratz <kratz00@gmx.de>
Uh oh!
There was an error while loading. Please reload this page.