Skip to content

Conversation

@thelovekesh
Copy link
Collaborator

  • Remove runtime-strict options from the config
  • Update runtime-wp and runtime-php to be KV inside the runtime
  • Remove default runtime strict and rather fallback to defined php and wp versions

@thelovekesh thelovekesh added the core changes made in cli core api label Jan 15, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @thelovekesh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the package configuration options related to runtime environment versions for WordPress and PHP. It introduces a nested runtime object to group these versions, enhancing configuration clarity. The explicit runtime-strict flag has been removed, with strictness now being implicitly determined by the presence of defined runtime versions. This change simplifies the configuration schema and streamlines the underlying logic for compatibility checks, making the system more intuitive and less verbose.

Highlights

  • Configuration Restructuring: The runtime-wp and runtime-php configuration options have been moved into a nested runtime object within wpm.json for a cleaner and more organized structure.
  • Removal of runtime-strict: The explicit runtime-strict boolean option has been removed from the configuration, simplifying the wpm.json schema.
  • Implicit Runtime Strictness: The system now implicitly enforces runtime version compatibility checks if runtime.wp or runtime.php versions are specified in the wpm.json configuration, removing the need for a separate strictness flag.
  • Codebase Adaptation: Internal logic for handling runtime versions has been updated across multiple files (cli/command/install/run.go, pkg/pm/resolution/resolver.go, pkg/pm/wpmjson/types/types.go, pkg/pm/wpmjson/wpmjson.go) to align with the new nested configuration structure and implicit strictness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

📦 wpm cli builds 📦

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the package configuration options by grouping runtime settings under a nested runtime object and removing the explicit runtime-strict flag. The changes are well-implemented across the codebase, including documentation, type definitions, and business logic. This simplification makes the configuration more intuitive and structured.

I have one suggestion to further improve maintainability by reducing code duplication in the resolver logic. Overall, this is a great improvement.

@thelovekesh thelovekesh merged commit 1f696d6 into main Jan 15, 2026
15 checks passed
@thelovekesh thelovekesh deleted the improve/package-config-options branch January 15, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core changes made in cli core api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants