-
Notifications
You must be signed in to change notification settings - Fork 1
Fix install command ux #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thelovekesh
commented
Jan 14, 2026
- Update command to bail if no new packages to install
Summary of ChangesHello @thelovekesh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience and functionality of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves the user experience of the install command by adding a check to exit early if there are no packages to install, which is a great addition. The documentation updates in the README are also very helpful. I've identified a few areas for improvement, including a case of code duplication that should be refactored, a minor regression in the command-line help text, and an inconsistency in the code examples in the documentation. My detailed feedback is in the comments below.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances the install command's user experience by adding new options, examples, and aliases. It also improves the command's behavior by gracefully handling cases where no packages need to be installed. The documentation in README.md has been updated to reflect these changes. Additionally, there's a nice refactoring of the default package configuration handling, which also fixes a potential bug where default values were not being applied correctly when a wpm.json file was read from disk. My review includes suggestions to improve documentation consistency and to replace a magic string with a more idiomatic Go sentinel error.