Skip to content

Conversation

@thelovekesh
Copy link
Collaborator

  • Update command to bail if no new packages to install

@gemini-code-assist
Copy link

Summary of Changes

Hello @thelovekesh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience and functionality of the install command by introducing intelligent checks to prevent unnecessary operations and providing clearer feedback. It also expands the wpm.json configuration capabilities, allowing for more detailed dependency management and project-specific settings. These changes aim to make the package manager more robust and user-friendly, particularly for new projects or when managing complex dependency trees.

Highlights

  • Improved Install Command User Experience: The install command now includes checks to bail out early if no wpm.json file is found (when no specific packages are provided) or if there are no packages (dependencies or dev dependencies) specified in the wpm.json to install, providing clearer feedback to the user.
  • Expanded install Command Documentation: The README.md has been updated to include comprehensive documentation for the install command, detailing new flags such as --no-dev, --ignore-scripts, --dry-run, --save-dev, --save-prod, and --network-concurrency.
  • Enhanced wpm.json Configuration: The wpm.json example and documentation have been extended to support requires (minimum requirements), devDependencies, and a config section with options like bin-dir, content-dir, runtime-wp, runtime-php, and runtime-strict.
  • Internal Refactoring for Default Configurations: The wpmjson package underwent refactoring, renaming an internal field from packageConfig to defaultPackageConfig and moving its initialization to the Read() function. This ensures default package configurations are consistently applied when a wpm.json file is loaded.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the user experience of the install command by adding a check to exit early if there are no packages to install, which is a great addition. The documentation updates in the README are also very helpful. I've identified a few areas for improvement, including a case of code duplication that should be refactored, a minor regression in the command-line help text, and an inconsistency in the code examples in the documentation. My detailed feedback is in the comments below.

@github-actions
Copy link

📦 wpm cli builds 📦

@thelovekesh
Copy link
Collaborator Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the install command's user experience by adding new options, examples, and aliases. It also improves the command's behavior by gracefully handling cases where no packages need to be installed. The documentation in README.md has been updated to reflect these changes. Additionally, there's a nice refactoring of the default package configuration handling, which also fixes a potential bug where default values were not being applied correctly when a wpm.json file was read from disk. My review includes suggestions to improve documentation consistency and to replace a magic string with a more idiomatic Go sentinel error.

@thelovekesh thelovekesh merged commit c373614 into main Jan 14, 2026
15 checks passed
@thelovekesh thelovekesh deleted the fix/install-command-ux branch January 14, 2026 20:39
@thelovekesh thelovekesh added the command any changes to the wpm cli command label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command any changes to the wpm cli command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants