VolumeIntegralAdaptive with VolumeIntegralSubcellLimiting for 3D TreeMesh

[DanielDoehring]

Follows #2924

[github-actions]

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

• The PR has a single goal that is clear from the PR title and/or description.
• All code changes represent a single set of modifications that logically belong together.
• No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

• The code can be understood easily.
• Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
• There are no redundancies that can be removed by simple modularization/refactoring.
• There are no leftover debug statements or commented code sections.
• The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

• New functions and types are documented with a docstring or top-level comment.
• Relevant publications are referenced in docstrings (see example for formatting).
• Inline comments are used to document longer or unusual code sections.
• Comments describe intent ("why?") and not just functionality ("what?").
• If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

• The PR passes all tests.
• New or modified lines of code are covered by tests.
• New or modified tests run in less then 10 seconds.

Performance

• There are no type instabilities or memory allocations in performance-critical parts.
• If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

• The correctness of the code was verified using appropriate tests.
• If new equations/methods are added, a convergence test has been run and the results
  are posted in the PR.

Created with ❤️ by the Trixi.jl community.

[codecov]

Codecov Report

❌ Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.13%. Comparing base (c8f75b5) to head (cc4b079).

Files with missing lines	Patch %	Lines
src/solvers/dgsem_tree/subcell_limiters_3d.jl	93.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
+ Coverage   97.00%   97.13%   +0.13%     
==========================================
  Files         625      625              
  Lines       48514    48544      +30     
==========================================
+ Hits        47057    47150      +93     
+ Misses       1457     1394      -63     

Flag	Coverage Δ
unittests	97.13% <94.74%> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bennibolm]

Wow, that was straight forward. Thanks a lot!

[bennibolm]

Ah, one thing. Do we want to add a comment to NEWS.md?

[bennibolm]

And one more thing. Maybe it would be good to add a comment (and also add it to the output) to the subcell bounds check that the bounds are only checked in elements where subcell limiting is used.

[DanielDoehring]

And one more thing. Maybe it would be good to add a comment (and also add it to the output) to the subcell bounds check that the bounds are only checked in elements where subcell limiting is used.

Can you add such a suggestion?

[bennibolm]

I added the comment and updated NEWS.md. Please check those changes and then we can merge this. @DanielDoehring

[DanielDoehring]

I added the comment and updated NEWS.md. Please check those changes and then we can merge this. @DanielDoehring

Thanks a lot! This is good to go from my side!