Safely Terminate Aggregator#362
Conversation
AskewParity
left a comment
There was a problem hiding this comment.
Thanks for doing this, it should free a good amount of resources if our CV models are decent Lol.
I think this PR could be accomplished using C++'s thread management itself. That method probably reduces the complexity and increases the stability/reliability of shutting down the threads.
There were originally more comments over specific implementation techniques, but we can revisit them at a later time if we are keeping this solution.
|
Also, while reviewing this PR. I don't think I/we have a good definition of what CVAggregator is supposed to be. It is possible to be initialized multiple times under different circumstances. We should decide on (and document) what CV aggregator is and how it interacts with the mission loop+other things. What I imagined before now was that CV aggregator was the module that the mission state/loop communicated to in order to access CV pipeline results.
|
AskewParity
left a comment
There was a problem hiding this comment.
Thanks for making this rewrite of the PR. I think it is more maintainable now.
I just have one clerical change to make.
Closes #324
We now: