Feat/mockanddocker - #15
Merged
Merged
Conversation
miyatakazuya
force-pushed
the
feat/mockanddocker
branch
2 times, most recently
from
May 8, 2026 02:00
72a2f42 to
41f265f
Compare
Contributor
|
I can run and build it on my mac (not my desktop, but I haven't investigated why). I don't get very far in running it since there are no mock images. Where should I get the mock images? In lieu of that, the README should be updated. |
Contributor
Author
|
images from the last test flight This should go in the images folder, I wasn't sure if we should just have the images in the repo... But i will update the README |
AskewParity
requested changes
May 13, 2026
AskewParity
left a comment
AskewParity
left a comment
Contributor
There was a problem hiding this comment.
I tested it, it looks good with the exception of two things
- I could not build on my x86 machine
- When running the binary, I get
[22:37:48.061218138] [20] ERROR DmaBufAllocator dma_buf_allocator.cpp:119 Could not open any dma-buf provider
The request changes is mainly for the README.
Comment on lines
+47
to
+53
| bool should_send = false; | ||
| RPICam::send_count_mutex.lock(); | ||
| if (RPICam::send_count > 0) { | ||
| RPICam::send_count--; | ||
| should_send = true; | ||
| } | ||
| RPICam::send_count_mutex.unlock(); |
Contributor
There was a problem hiding this comment.
should probably use continue instead of the boolean
| LOG_F(WARNING, "Image dimensions %dx%d do not match config %dx%d. Processing might be corrupted.", img_w, img_h, width, height); | ||
| } | ||
|
|
||
| // YUV420 Conversion |
Contributor
There was a problem hiding this comment.
Do we not have a function for this? Lol
AskewParity
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16 #17
Implements
mock_camera, which allows the server to work without a physical camera for testing purposes.picam.json(ex. Image size, network, timeouts, etc).Testing:
make build-docker.