Skip to content

Add warning when sending credentials over HTTP#593

Open
hashhar wants to merge 1 commit intotrinodb:masterfrom
hashhar:hashhar/improve-http-scheme
Open

Add warning when sending credentials over HTTP#593
hashhar wants to merge 1 commit intotrinodb:masterfrom
hashhar:hashhar/improve-http-scheme

Conversation

@hashhar
Copy link
Member

@hashhar hashhar commented Mar 6, 2026

Description

Adds warning when sending credentials over HTTP. JDBC actually disallows this entirely but it can be a breaking change for Python client now.

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

* Fix some things. ({issue}`issuenumber`)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a runtime warning when authentication is configured while using an insecure HTTP connection, to help prevent accidental credential exposure.

Changes:

  • Emit a UserWarning in Connection.__init__ when auth is set and the resolved scheme is HTTP.
  • Add unit tests asserting the warning is produced for HTTP and not produced for HTTPS.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
trino/dbapi.py Adds warning emission when auth is used over HTTP.
tests/unit/test_dbapi.py Adds/updates tests to validate the new warning behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hashhar hashhar force-pushed the hashhar/improve-http-scheme branch from 828a7c7 to ae59fe2 Compare March 6, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants