improvements on current gtk-4 drastic branch#380
Conversation
seems to fix few known issues - changing the text side option from the settings menu wouldn't update the overlay right away - somehow adding an initial padding when opened on a environment with no previous config still not sure if this is the right way to fix this.
grk color button is deprecated, migrated to gtk color dialog
…ed and config set correctly _param=None is just another param because i had to change to a different signal (to notifiy::rgba)
…button after reading config file seems this is the way to initialize RGBA now
…hole user with name also fixes the border showing on the background while avatar is transparent
…together gtk box was created to have a separete css class so only avatar gets affected when changing the opacity
|
had plans to do more with this, and i might if i get free again but for now i will get busy so i wanted to create this PR to share how much i have done so far, check on this when you can and tell me if you need some changes on this |
|
Over all no complaints
I prefer my PRs to not mix different things together so it is easier to review changes individually :) This is a good size The outline/dropshadow thing is something I tested myself and ended up with dropshadow because it matches the gtk3/cairo version behaviour, and was an option labeled 'Fancy avatar shapes' ( Discover/discover_overlay/glade/settings.glade Line 1221 in ccbee7a |
|
I don't know about the fancy avatar shapes, this PR is merge request to your PR branch, so i think merging this will add changes to your PR, maybe you or i can comment about this PR to that(about the changes), then i think you can have one PR that you can work on :p |
2 participants
few main improvements involves:
known caveats that still exist: