fix: add Visibility schema to keypoint template, fix sample data sizes#68
Open
shujaatTracebloc wants to merge 4 commits intodevelopfrom
Open
fix: add Visibility schema to keypoint template, fix sample data sizes#68shujaatTracebloc wants to merge 4 commits intodevelopfrom
shujaatTracebloc wants to merge 4 commits intodevelopfrom
Conversation
- Add Visibility column to keypoint schema so client can read visibility flags - Diversify keypoint labels (person, athlete, dancer) to meet min 2 labels requirement - Resize keypoint sample images from 256x256 to 448x448 to match target_size - Resize semantic segmentation sample images and masks to 512x512 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
👋 Heads-up — Code review queue is at 10 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…patibility - Add Annotation and Visibility to schema instead of using annotation_column - Preserves column case so client can read row["Annotation"] and row["Visibility"] - Change target_size to (256, 256) to match actual data - Add DataValidator for keypoint schema validation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0893ff1. Configure here.
| # Keypoint detection specific options | ||
| keypoint_detection_options = { | ||
| "target_size": (448, 448), # image size. Height = Width | ||
| "target_size": (256, 256), # image size. Height = Width |
There was a problem hiding this comment.
Target size changed in wrong direction, breaking validation
High Severity
The target_size is changed from (448, 448) to (256, 256), but the PR description states the sample images were resized from 256×256 to 448×448 to match target_size. This reversal means the ImageResolutionValidator will now expect 256×256 images but receive 448×448 images, causing all keypoint detection validation to fail.
Reviewed by Cursor Bugbot for commit 0893ff1. Configure here.
Framework stores annotation as lowercase `annotation` in DB. Use annotation_column parameter to map CSV Annotation column correctly. Client PR tracebloc/tracebloc-client#252 reads row["annotation"]. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add KeypointAnnotationValidator to validate annotation JSON structure, coordinate ranges, bbox feasibility, visibility values, and keypoint count consistency before ingestion - Fix sample CSV to use normalized [0,1] coordinates instead of pixel values to prevent zero-area bbox errors during client training - Wire validator into keypoint detection validator mapping Closes #70 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: changes are additive and template-focused, with the new
DataValidatoronly enabled when a schema is provided for keypoint ingestion.Overview
Adds an explicit
Visibilitycolumn schema to the keypoint-detection ingestion template and passes it intoCSVIngestorso visibility flags can be validated/consumed.Updates shared validator mapping for
KEYPOINT_DETECTIONto optionally includeDataValidatorwhen a schema is supplied, and adjusts the keypoint template’starget_sizeplus sample CSV labels (diversifiedimage_labelvalues).Reviewed by Cursor Bugbot for commit 6e48371. Bugbot is set up for automated code reviews on this repo. Configure here.