Skip to content

ci: drop push-tags trigger from release-helm-chart workflow #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saadqbal merged 3 commits into from
May 7, 2026
Merged

ci: drop push-tags trigger from release-helm-chart workflow #117

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
044d4d1
ci: drop push-tags trigger from release-helm-chart workflow
saadqbal May 7, 2026
12c7a4c
ci: harden release-asset upload against actions/runner#2788
saadqbal May 7, 2026
4466e0c
ci: pin checkout ref to release tag (actions/runner#2788 hardening)
saadqbal May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/release-helm-chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
name: Release Helm Chart

on:
push:
tags:
Comment thread
cursor[bot] marked this conversation as resolved.
- 'client-v*'
- 'v*'
Comment thread
cursor[bot] marked this conversation as resolved.
release:
types: [published]

Expand All @@ -26,8 +22,14 @@ jobs:
id-token: write
steps:
- name: Checkout
# Pin ref to the release tag rather than letting checkout default to
# github.ref, which intermittently arrives empty on release-triggered
# runs (actions/runner#2788, still open). An empty default would cause
# checkout to fall back to the repo default branch and package the
# chart from the wrong commit.
uses: actions/checkout@v4
with:
ref: ${{ github.event.release.tag_name }}
fetch-depth: 0

- name: Set up Helm
Expand Down Expand Up @@ -101,10 +103,13 @@ jobs:
git push origin gh-pages
fi

- name: Upload chart to GitHub Release (on tag)
if: startsWith(github.ref, 'refs/tags/')
- name: Upload chart to GitHub Release
# Pin tag_name from the release event payload rather than relying on
# github.ref / github.ref_name, which intermittently arrive empty on
# release-triggered runs (actions/runner#2788, still open).
uses: softprops/action-gh-release@v2
with:
tag_name: ${{ github.event.release.tag_name }}
files: client-*.tgz
generate_release_notes: true
env:
Expand Down