chore(auto-upgrade): run cronjob hourly at :23#112
Merged
Conversation
Contributor
|
👋 Heads-up — Code review queue is at 11 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
4 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3cbde1c. Configure here.
Switches the auto-upgrade CronJob default schedule from "23 2 * * *" (daily 02:23 UTC) to "23 * * * *" (hourly at :23). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3cbde1c to
66252c7
Compare
aptracebloc
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
autoUpgrade.schedulefrom"23 2 * * *"(daily 02:23 UTC) to"23 * * * *"(hourly at :23) so deployed clients converge on the latest chart within ~1h instead of ~24h.mainso prod gets only this change without pulling unshippeddevelopcommits along with it.Closes #111 (dev side — the prod-side PR will reference the same ticket).
Test plan
helm template ... | grep -A1 schedule:shows23 * * * *on a fresh renderclient/tests/auto_upgrade_test.yamlstill passes (helm unittest client/)kubectl get cronjob -n <ns> -l app.kubernetes.io/component=auto-upgradeshows the hourly schedule🤖 Generated with Claude Code
Note
Low Risk
Low risk: only changes the default
CronJobschedule and its unit test expectation, with no changes to the upgrade logic itself. The main impact is increased upgrade/check frequency (more cluster activity and repo polling).Overview
Switches the default
autoUpgrade.schedulefrom daily"23 2 * * *"to hourly"23 * * * *", so the self-upgradeCronJobchecks/applies chart updates up to once per hour.Updates the Helm unittest (
client/tests/auto_upgrade_test.yaml) to assert the new default schedule.Reviewed by Cursor Bugbot for commit 66252c7. Bugbot is set up for automated code reviews on this repo. Configure here.