Skip to content

Conversation

@JeongHwan-dev
Copy link
Contributor

📝 Key Changes

Fix incorrect "selected" state display in screen reader output example

What's Fixed

  • Updated screen reader output to show "selected" state on the correct tab (Feed)
  • Ensured consistency between code example and screen reader output

Problem Solved

The code example shows Feed tab with aria-selected={true}, but the screen reader output example incorrectly showed "selected" state on Home tab instead.

🖼️ Before and After Comparison

Code Example:

<div role="tablist" aria-label="메뉴">
  <button role="tab" aria-selected={false}></button>
  <button role="tab" aria-selected={false}>
    관심
  </button>
  <button role="tab" aria-selected={false}>
    발견
  </button>
  <button role="tab" aria-selected={true}>
    피드
  </button>
</div>

Before (Incorrect output):
메뉴, 탭 목록
홈, 선택됨, 탭 ← ❌ Incorrect
관심, 탭
발견, 탭
피드, 탭

After (Correct output):
메뉴, 탭 목록
홈, 탭
관심, 탭
발견, 탭
피드, 선택됨, 탭 ← ✅ Correct

@vercel
Copy link

vercel bot commented Dec 7, 2025

@JeongHwan-dev is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

@chhw130
Copy link
Contributor

chhw130 commented Dec 15, 2025

@JeongHwan-dev Hi! I have an existing PR for this issue(#698). Could you check it out?

@milooy
Copy link
Collaborator

milooy commented Dec 19, 2025

Thank you for your contribution!
Will close this PR (duplicate with #698)

@milooy milooy closed this Dec 19, 2025
@JeongHwan-dev
Copy link
Contributor Author

@JeongHwan-dev Hi! I have an existing PR for this issue(#698). Could you check it out?

@chhw130
Oh, I missed the existing PR, Thanks for pointing it out. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants