feat: add offline map style switcher - #68
Open
torlando-tech wants to merge 4 commits into
Open
Conversation
Contributor
Greptile SummaryThe PR adds a four-style offline-map catalog and transactional style activation across the firmware and browser installer.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant MapScreen
participant Worker
participant Catalog as MapStyleCatalog
participant Pack as MapTilePack
User->>MapScreen: Cycle style
MapScreen->>MapScreen: Queue request with lifecycle epoch
MapScreen->>Worker: Notify
Worker->>Worker: Validate visibility and epoch
Worker->>Catalog: Activate selected snapshot
Catalog-->>Worker: Durable catalog result
Worker->>Pack: Reload active pack
Worker->>MapScreen: Reconcile selector and invalidate tiles
alt Screen hidden before request is claimed
MapScreen->>MapScreen: Advance epoch and cancel request
else Screen hidden after request is claimed
Worker->>MapScreen: Reconcile without retaining stale errors
end
Reviews (2): Last reviewed commit: "fix: serialize map style activation life..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safety properties
Verification
pio run -e tdeckpassed for the firmware commitpio run -e tdeck-releaseand release audit passed for the firmware commitPhysical validation status
The exact firmware application was flashed and read back successfully, with OTA selection stable across two boots and no panic/watchdog signatures. The SD card now contains valid snapshots for all four styles. Final on-device cycling through all four styles remains a manual acceptance check after reinserting the safely unmounted SD card.