docs: add guided offline map installation steps - #64
Merged
Conversation
Contributor
Greptile SummaryThe PR adds a guided five-step offline-map installation workflow and closes the previous downloader-compatibility coverage gap.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "test: cover recommended map downloader a..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+33
to
+37
| assert ( | ||
| 'href="https://download.tiles.coalition.space/" ' | ||
| 'target="_blank" rel="noopener noreferrer"' | ||
| ) in source | ||
| expected_steps = ( |
Contributor
There was a problem hiding this comment.
The new contract checks only the downloader URL and instructional text, while importer tests use synthetic ZIPs rather than a representative downloader archive. Add a representative fixture covering the installer’s ZIP constraints so changes to the recommended archive format do not leave the advertised workflow passing tests while local validation rejects it.
Knowledge Base Used: Release Build, Packaging, and Web Flasher
Prompt To Fix With AI
This is a comment left during a code review.
Path: tests/build_scripts/test_map_web_installer_contract.py
Line: 33-37
Comment:
**Downloader compatibility lacks coverage**
The new contract checks only the downloader URL and instructional text, while importer tests use synthetic ZIPs rather than a representative downloader archive. Add a representative fixture covering the installer’s ZIP constraints so changes to the recommended archive format do not leave the advertised workflow passing tests while local validation rejects it.
**Knowledge Base Used:** [Release Build, Packaging, and Web Flasher](https://app.greptile.com/torlando-tech/-/custom-context/knowledge-base/torlando-tech/pyxis/-/docs/release-build-and-flasher.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Greptile remediation
The representative 1,162-byte fixture reproduces the recommended downloader's compatibility-relevant ZIP envelope without retaining its geographic tile payloads or identifying coverage:
The browser test mechanically checks those traits, validates zoom 0–2 coverage, installs the archive, and verifies the published PNG bytes. No production importer behavior changed.
Verification
python3 -m pytest -q tests/build_scripts tests/native tests/tools— 254 passedpython3 -m pytest -q tests/build_scripts/test_map_web_installer_contract.py— 4 passednode --check docs/flasher/js/map-installer.js— passednode --test tests/web/test_map_installer.mjs— 12 passedgit diff --check— passedScope
Documentation and web-flasher test guidance only. No firmware, map format, installer behavior, dependency, or release artifact changes.