Add interoperable LXMF voice messages - #1075
Merged
Merged
Conversation
Contributor
Greptile SummaryThe PR adds interoperable Ogg/Opus LXMF voice messages across recording, playback, persistence, retry, and Binder transport.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant UI as Messaging UI
participant VM as MessagingViewModel
participant Audio as Recorder / Player
participant Repo as ConversationRepository
participant IPC as RNS IPC
participant Peer as LXMF Peer
UI->>VM: Record and send voice message
VM->>Audio: Record finalized Ogg/Opus
Audio-->>VM: Audio bytes
VM->>Repo: Persist FIELD_AUDIO
VM->>IPC: Send [AM_OPUS_OGG, bytes]
IPC->>Peer: Deliver LXMF message
Peer-->>IPC: Receive FIELD_AUDIO
IPC->>Repo: Persist inline or extracted payload
Repo-->>VM: Load message
VM->>Audio: Resolve, validate, and play payload
Audio-->>UI: Metadata, waveform, and playback state
Reviews (4): Last reviewed commit: "fix: always release voice recording leas..." | Re-trigger Greptile |
# Conflicts: # app/src/main/java/network/columba/app/ui/screens/MessagingScreen.kt
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FIELD_AUDIOrepresentation with Ogg/Opus payloadsv0.0.8, with permission handling, preview, cancellation, failure recovery, persistence, and retryFixes #463
Verification completed
LOCAL_LXST_KTunset against published LXSTv0.0.8Verification still running
10fc50a9a483594821044b23f645499c048ba9d7Risk and rollback
The highest-risk areas are Android microphone lifecycle ownership, binary attachment persistence, and playback metadata concurrency. The implementation uses tokenized microphone leases, bounded loading, atomic metadata admission, stale-cache cleanup, and regression coverage for duplicate starts, stale releases, retry reconstruction, and failed recorder finalization. Rollback is the removal of this feature stack and the LXST dependency pin update.