Skip to content

fix: render NomadNet six-digit true colors - #1071

Merged
torlando-tech merged 5 commits into
mainfrom
fix/nomadnet-true-color
Aug 4, 2026
Merged

fix: render NomadNet six-digit true colors#1071
torlando-tech merged 5 commits into
mainfrom
fix/nomadnet-true-color

Conversation

@torlando-tech

Copy link
Copy Markdown
Owner

Summary

  • parse six-digit Micron foreground and background colors emitted by NomadNet
  • consume complete true-color control sequences instead of leaking fragments into rendered text
  • add parser regressions and a Compose rendering regression
  • select the physical rendering regression in the existing CI emulator lane

Verification

  • Micron unit suite
  • Micron and app ktlint/detekt
  • Kotlin instrumentation APK assembly
  • physical Galaxy S21 Ultra true-color rendering regression

Risk and rollback

The parser change is limited to six-digit color controls while preserving existing short color behavior. Reverting this PR restores the previous parser and removes the added CI test selection.

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds six-digit RGB support specifically for inline Micron FT and BT controls while preserving existing page-directive and short-color behavior.

  • Introduces a dedicated true-color parser used only by inline formatting commands.
  • Consumes complete true-color control payloads so command fragments do not appear as rendered text.
  • Adds parser and Compose rendering regressions and selects the device test in CI.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
micron/src/main/java/network/columba/app/micron/MicronColor.kt Separates six-digit inline true-color parsing from the shared three-character parser, resolving the previously reported directive-scope expansion.
micron/src/main/java/network/columba/app/micron/MicronParser.kt Recognizes FT and BT controls, parses six hexadecimal digits, and advances past the entire valid sequence.
micron/src/test/java/network/columba/app/micron/MicronParserTest.kt Covers valid, malformed, and truncated true-color controls and confirms page directives continue rejecting six-digit values.
app/src/androidTestDebug/java/network/columba/app/ui/components/MicronTrueColorRenderingTest.kt Adds an end-to-end Compose regression checking rendered text and the expected true-color background.
.github/workflows/ci.yml Adds the true-color rendering regression to the existing connected-device test selection.

Reviews (3): Last reviewed commit: "test malformed micron true colors" | Re-trigger Greptile

Comment thread micron/src/main/java/network/columba/app/micron/MicronColor.kt Outdated
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@torlando-tech
torlando-tech merged commit c0debe5 into main Aug 4, 2026
12 checks passed
@torlando-tech
torlando-tech deleted the fix/nomadnet-true-color branch August 4, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant