Pr 1203#1204
Closed
ahmedemam576 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
christian-pinto
requested changes
Jul 2, 2026
christian-pinto
left a comment
christian-pinto
left a comment
Collaborator
There was a problem hiding this comment.
This PR includes code from another PR #1203, please remove that code and push again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
RF-DETR version got an update.
Some versions expect 2 values from the backbone, newer ones expect 3(Features, Positions, cross-attn-features [new]).
Our code always returned 2, so tests failed with:
expected 3, got 2.
Fix:
I updated terratorch/models/detr/terratorch_detr.py to support both cases[set the cross-attn-features to None and ignore it in the next steps ].
It now retries once and switches to the right format automatically.