Feat/fix empty pod phase#715
Open
wls-villani-ed wants to merge 6 commits into
Open
Conversation
Downgrade several high-frequency Info logs to Debug to reduce production log noise. Change orphaned room cleanup log from Info to Warn since it indicates a data inconsistency worth monitoring. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a pod is freshly created, K8s hasn't set the phase yet and it comes as an empty string. The default branch in convertPodStatus was mapping this to InstanceError, causing unnecessary log noise and incorrect room status. Now treats empty phase as InstancePending. Also fixes PodFailed log level from Error back to Warn (accidentally promoted in 5667a81). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…mpty phase Adds tests for: empty phase, PodFailed, PodSucceeded, PodUnknown, pod deletion, container terminated (success/error), running without ready condition. Also adds "PodPhaseNotSet" description to the empty phase case. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.