fix: keep terminal multiline bindings buffer-local#385
Merged
tninja merged 1 commit intoJun 12, 2026
Conversation
tninja
reviewed
Jun 12, 2026
tninja
left a comment
Owner
There was a problem hiding this comment.
Thanks for the fix. I reviewed the diff and the keymap change looks good.
The current red unit-tests / ert check is not caused by this PR. I reproduced the same ai-code-test-session-checkpoint-sends-fixed-checkpoint-prompt failure on origin/main, so it is a pre-existing baseline issue unrelated to the multiline keymap changes here. I will fix that CI failure independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ai-code-backends-infra--configure-session-bufferusedlocal-set-key, which mutates the buffer's local keymap. Terminal buffers (eat/vterm) share their major-mode keymap as the local map, so bindingS-<return>/C-<return>/C-<escape>in one session buffer leaked those bindings into every other buffer of the same mode.Fix
copy-keymapof the current local map before defining any keys, so bindings stay confined to the session buffer.Tests
Added an ERT test verifying that configuring one buffer does not leak the multiline bindings into another buffer sharing the same mode map, and that the unconfigured buffer keeps its original bindings.