Skip to content

Fix issues with git formatted patches.#2

Open
mtyson01 wants to merge 1 commit intotmannerm:masterfrom
mtyson01:master
Open

Fix issues with git formatted patches.#2
mtyson01 wants to merge 1 commit intotmannerm:masterfrom
mtyson01:master

Conversation

@mtyson01
Copy link

@mtyson01 mtyson01 commented Jun 5, 2014

In a patch file that has a message or some other text prior to
the commit data, PatchReader will treat any lines that start with
whitespace as actual patch data, causing mangled output.

Also the '-- ' that git places at the end of the patch data will
be parsed as patch data and included in the raw output.

In a patch file that has a message or some other text prior to
the commit data, PatchReader will treat any lines that start with
whitespace as actual patch data, causing mangled output.

Also the '-- ' that git places at the end of the patch data will
be parsed as patch data and included in the raw output.
@mtyson01
Copy link
Author

mtyson01 commented Jun 5, 2014

The problem was noticed with this patch:

https://bugzilla.redhat.com/attachment.cgi?id=463663

The mangled output looks like this:

@@ -, +, @@ 
 Signed-off-by: W. Michael Petullo <mike@flyn.org>
---
 new-kernel-pkg |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
--- a/new-kernel-pkg    
+++ a/new-kernel-pkg    
@@ -89,8 +89,8 @@ moddep=""
 verbose=""
 makedefault=""
 package=""
-mbkernel=""
-mbargs=""
+mbkernel="$HYPERVISOR"
+mbargs="$HYPERVISOR_ARGS"
 adddracutargs=""
 addplymouthinitrd=""

-- 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant