fix(darwin): add DidUpdateNotificationState when enabling notifications#433
Open
acouvreur wants to merge 1 commit intotinygo-org:devfrom
Open
fix(darwin): add DidUpdateNotificationState when enabling notifications#433acouvreur wants to merge 1 commit intotinygo-org:devfrom
acouvreur wants to merge 1 commit intotinygo-org:devfrom
Conversation
Currently, enabling notifications does not check for errors.
| var err error | ||
| select { | ||
| case err = <-c.notifyChan: | ||
| case <-time.NewTimer(10 * time.Second).C: |
Contributor
There was a problem hiding this comment.
time.After is the same but shorter :)
| select { | ||
| case err = <-c.notifyChan: | ||
| case <-time.NewTimer(10 * time.Second).C: | ||
| err = errors.New("timeout on EnableNotifications") |
Contributor
There was a problem hiding this comment.
you should define the error on the top of the file (the same as errCannotSendWriteWithoutResponse) to avoid allocation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, enabling notifications does not check for errors.