Add PATH persistence and shell command refresh hints to installer#2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
localsend-cli.Description
print_command_refresh_hintto print shell-specific instructions to refresh command lookup forzsh,bash/ksh/ash/dash/sh,fish, and a generic fallback.persist_path_hintwhich writes a shell-appropriate PATH update into the user's rc file (~/.zshrc,~/.bashrc, or~/.config/fish/config.fish) if the line is not already present and creates the parent directory as needed.persist_path_hint "$dir"when the chosen install directory is not onPATH, and callprint_command_refresh_hintbefore the final usage hint.infowhile preserving existing install flow.Testing
bash -n install.shwhich succeeded.shellcheck install.shwhich reported no critical failures.Codex Task