-
Notifications
You must be signed in to change notification settings - Fork 753
core: region heartbeat with bucket meta #10120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
core: region heartbeat with bucket meta #10120
Conversation
Signed-off-by: tongjian <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: bufferflies <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10120 +/- ##
=======================================
Coverage 78.42% 78.43%
=======================================
Files 518 518
Lines 69493 69407 -86
=======================================
- Hits 54503 54442 -61
+ Misses 11042 11024 -18
+ Partials 3948 3941 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@bufferflies: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| if hasBuckets { | ||
| if old := origin.GetBuckets(); buckets[i].GetVersion() > old.GetVersion() { | ||
| region.UpdateBuckets(buckets[i], old) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use SetBucketMeta, do we still need UpdateBuckets?
What problem does this PR solve?
Issue Number: Close #10117
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tiup:Release note