Skip to content

Conversation

@bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Dec 25, 2025

What problem does this PR solve?

Issue Number: Close #10117

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Signed-off-by: tongjian <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. labels Dec 25, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign siddontang for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 25, 2025
@bufferflies bufferflies changed the title core: region with bucket meta core: region heartbeat with bucket meta Dec 26, 2025
Signed-off-by: bufferflies <[email protected]>
@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.43%. Comparing base (6bfdb20) to head (bd6a2a2).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10120   +/-   ##
=======================================
  Coverage   78.42%   78.43%           
=======================================
  Files         518      518           
  Lines       69493    69407   -86     
=======================================
- Hits        54503    54442   -61     
+ Misses      11042    11024   -18     
+ Partials     3948     3941    -7     
Flag Coverage Δ
unittests 78.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bufferflies bufferflies marked this pull request as ready for review December 29, 2025 07:08
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 29, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2025

@bufferflies: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test-next-gen-3 bd6a2a2 link true /test pull-unit-test-next-gen-3

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


if hasBuckets {
if old := origin.GetBuckets(); buckets[i].GetVersion() > old.GetVersion() {
region.UpdateBuckets(buckets[i], old)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use SetBucketMeta, do we still need UpdateBuckets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Region heartbeat should carry with the region bucket meta

2 participants