-
Notifications
You must be signed in to change notification settings - Fork 752
labeler: fix deleting non-existing label rule should return 404 (#10090) #10098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
labeler: fix deleting non-existing label rule should return 404 (#10090) #10098
Conversation
ref tikv#9854, close tikv#10089 Signed-off-by: ti-chi-bot <[email protected]>
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lhy1024 This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: lhy1024 <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #10098 +/- ##
===============================================
+ Coverage 77.81% 77.87% +0.05%
===============================================
Files 482 482
Lines 65343 65343
===============================================
+ Hits 50846 50885 +39
+ Misses 10743 10719 -24
+ Partials 3754 3739 -15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #10090
What problem does this PR solve?
Issue Number: Close #10089 ref #9854
What is changed and how does it work?
Check List
Tests
Release note