refactor: migrate unit portfolios state to Angular component#448
Open
millyamolo wants to merge 6 commits intothoth-tech:10.0.xfrom
Open
refactor: migrate unit portfolios state to Angular component#448millyamolo wants to merge 6 commits intothoth-tech:10.0.xfrom
millyamolo wants to merge 6 commits intothoth-tech:10.0.xfrom
Conversation
Replace the legacy AngularJS portfolios controller/template with a downgraded Angular component. This keeps the route while moving tab/filter/grading behavior onto the Angular 17 path. Made-with: Cursor
millyamolo
force-pushed
the
feat/angular17-portfolios-migration
branch
from
bd59ce9 to
736a742
Compare
millyamolo
force-pushed
the
feat/angular17-portfolios-migration
branch
from
e832e0b to
ee4bb41
Compare
millyamolo
force-pushed
the
feat/angular17-portfolios-migration
branch
from
95705c7 to
7b42dae
Compare
MatChipListbox is not an NgModule; MatChipsModule already provides chip listbox. Portfolios: migrate state to Angular component shell, drop duplicate legacy template/controller wiring from portfolios.tpl.html and portfolios.coffee. Made-with: Cursor
WaelAlahamdi
approved these changes
Apr 6, 2026
WaelAlahamdi
left a comment
WaelAlahamdi
left a comment
There was a problem hiding this comment.
Reviewed locally and tested successfully. The migration now keeps the portfolios route on the Angular wrapper, restores the progress dashboard path, and covers the expected portfolios flow across Select Student, View Progress, View Staff Notes, View Portfolio, and Assess Portfolio. Approved.
davidngash98
reviewed
Apr 7, 2026
There was a problem hiding this comment.
Reviewed following OnTrack guidelines and everything works as described.
The migration from AngularJS to Angular 17 is clean, the downgrade bridge is consistent with the rest of the codebase and all three tabs (Select Student, View Portfolio, Assess Portfolio) function correctly. The grade tab save flow works without issues.
Excellent work
davidngash98
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the legacy AngularJS portfolios controller/template with a downgraded Angular component. This keeps the route while moving tab/filter/grading behavior onto the Angular 17 path.
Summary
portfolios.tpl.htmlas a wrapper that renders<f-portfolios>.Before / After Screenshots
Before (AngularJS)
After (Angular 17)