feat(react-lang): support custom host wrappers for React Native#572
Open
greatjourney589 wants to merge 1 commit into
Open
feat(react-lang): support custom host wrappers for React Native#572greatjourney589 wants to merge 1 commit into
greatjourney589 wants to merge 1 commit into
Conversation
Author
|
Hi, @vishxrad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #523
Add support for custom host wrappers in
@openui/react-lang'sRendererso it can render on non-web hosts like React Native / Expo.Today the
Rendererhardcodes<div>for its outer and inner wrappers and always falls back to a DOM spinner. On React Native, lowercase host tags like"div"are not valid components and crash with "View config getter callback for componentdiv...". This change lets callers supply native host components (e.g.Viewfromreact-native) instead.Changes
containerComponentandcontentComponentprops toRendererProps(default to"div"), so the outer/inner wrappers can be swapped for native hosts.opacityfade transition only when the content wrapper is a web host (string tag); skip it for native components to avoid warnings/crashes.queryLoader.react-dom+@types/react-domas devDependencies and avitest.config.tsto support component tests.Renderertests covering default webdivwrappers, custom native wrappers, transition omission on native, and null-response rendering.packages/react-lang/README.mdwith React Native usage docs.Test Plan
Describe how you validated this change.
vitest runinpackages/react-langpasses (4/4 tests), covering web defaults, native wrappers, web-only transition handling, and null responses.Checklist
"div", so existing web usage is unchanged.