ASoC: SOF: Intel: hda: follow strict BDLE address alignment for ACE4#5684
Draft
kv2019i wants to merge 1 commit intothesofproject:topic/sof-devfrom
Draft
ASoC: SOF: Intel: hda: follow strict BDLE address alignment for ACE4#5684kv2019i wants to merge 1 commit intothesofproject:topic/sof-devfrom
kv2019i wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
Intel ACE4 based products require host to strictly follow HDA spec guidance on BDLE address alignment. Each BDLE address must be aligned to 128 bytes, and given ALSA periods are directly mapped to BDLEs, period size must be 128 aligned as well. Reported-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
ujfalusi
reviewed
Mar 6, 2026
| snd_pcm_hw_constraint_step(substream->runtime, 0, SNDRV_PCM_HW_PARAM_PERIOD_BYTES, 4); | ||
| if (chip_info->hw_ip_version >= SOF_INTEL_ACE_4_0) | ||
| snd_pcm_hw_constraint_step(substream->runtime, 0, SNDRV_PCM_HW_PARAM_PERIOD_BYTES, | ||
| SOF_HDA_BDLE_ADDRESS_ALIGNMENT); |
Collaborator
There was a problem hiding this comment.
you also need to fix legacy HDA in sound/hda/controllers/intel.c and add AZX_DCAPS_NO_ALIGN_BUFSIZE to both NVL and NVL_S, probably by:
#define AZX_DCAPS_INTEL_NVL (AZX_DCAPS_INTEL_LNL | AZX_DCAPS_NO_ALIGN_BUFSIZE)
ujfalusi
reviewed
Mar 6, 2026
| /* SDxFIFOS FIFOS */ | ||
| #define SOF_HDA_SD_FIFOSIZE_FIFOS_MASK GENMASK(15, 0) | ||
|
|
||
| /* HDA BDLE size constraints */ |
Collaborator
There was a problem hiding this comment.
the alignment is for the address within the BDLE, iow to the start of a period.
ujfalusi
reviewed
Mar 6, 2026
| snd_pcm_hw_constraint_step(substream->runtime, 0, SNDRV_PCM_HW_PARAM_PERIOD_BYTES, | ||
| SOF_HDA_BDLE_ADDRESS_ALIGNMENT); | ||
| else | ||
| /* minimum as per HDA spec */ |
Collaborator
There was a problem hiding this comment.
I would remove this sentence and/or replace it with something which is correct (also for the legacy comment block, that is wrong in the same way)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intel ACE4 based products require host to strictly follow HDA spec guidance on BDLE address alignment. Each BDLE address must be aligned to 128 bytes, and given ALSA periods are directly mapped to BDLEs, period size must be 128 aligned as well.
Reported-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com