Preference settings #2344
Open
Preference settings #2344
+567
−310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preference-settings
…nd auto-play-next Introduce a new UserPreference class to manage per-user settings including theme (light/dark/system), font scale, and auto-play next lesson. This provides a centralized way to store and retrieve user-specific UI/UX preferences via WordPress user meta. - Add AJAX endpoint for saving preferences - Apply theme via data-theme attribute and font scale via CSS - Update dashboard and account templates with proper HTML structure - Extend frontend with new PreferenceService and settings UI - Integrate with existing Tutor core and Alpine.js components
nur-alam
requested review from
b-l-i-n-d,
harunollyo and
sazedul-haque
and removed request for
harunollyo and
sazedul-haque
b-l-i-n-d
requested changes
Jan 30, 2026
Fix inconsistent behavior when user preferences are empty by returning an empty array instead of false. This prevents type errors when merging preferences and ensures the default value is properly applied. Also rename variables for clarity and fix filter hook name consistency.
- Move hardcoded font scale options to a filterable method in UserPreference class - Remove unused preference service exposure and refactor theme initialization - Clean up font scale calculation by using constants and improve readability - Fix a typo in a success message string
Initialize mediaQuery and activeTheme in constructor instead of inline declaration to ensure proper setup order. Use constant for data-theme attribute to avoid magic strings. Change applyTheme parameter to Theme type for better type safety.
Replace hard-coded 'system' string literals with THEME.SYSTEM constant to improve maintainability and consistency across theme handling logic.
…ucture - Move hardcoded theme options array to UserPreference::get_theme_options() method - Define DEFAULT_THEME, DEFAULT_FONT_SCALE, and FONT_SCALE_OPTIONS constants - Use constants consistently across template, PHP class, and TypeScript service - Simplify font scaling logic in TypeScript by removing unnecessary wrapper function - Improve error message when saving preferences fails
harunollyo
requested changes
Feb 2, 2026
classes/UserPreference.php
Outdated
| return; | ||
| } | ||
|
|
||
| add_action( 'wp_ajax_tutor_save_user_preferences', array( $this, 'tutor_save_user_preferences' ) ); |
Collaborator
There was a problem hiding this comment.
Add prefix ajax to callback method. It's already in a namespace and inside class. Do not use tutor prefix
ajax_save_user_preferences
classes/UserPreference.php
Outdated
|
|
||
| update_user_meta( $user_id, self::META_KEY, $preferences ); | ||
|
|
||
| do_action( 'tutor_user_preference_data', $user_id, $preferences ); |
Collaborator
There was a problem hiding this comment.
tutor_user_preference_saved
classes/UserPreference.php
Outdated
| return array( | ||
| array( | ||
| 'label' => __( 'Light', 'tutor' ), | ||
| 'value' => 'light', |
Collaborator
There was a problem hiding this comment.
Create these value as const
const THEME_LIGHT = 'light';
const THEME_DARK = 'dark';
const THEME_SYSTEM = 'system';
b-l-i-n-d
approved these changes
Feb 2, 2026
Replace magic string theme values with named constants for better maintainability and type safety. Rename hook and method for consistency and update docblock types. Conditionally apply user preferences only on dashboard pages to prevent unintended side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.