Lesson comments implemented #2333
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-l-i-n-d
requested changes
Jan 28, 2026
shewa12
reviewed
Jan 29, 2026
shewa12
reviewed
Jan 29, 2026
|
|
||
| $comment_id = 0; | ||
| $comment = Input::post( 'comment', '', Input::TYPE_KSES_POST ); | ||
| $lesson_id = Input::post( 'comment_post_ID', 0, Input::TYPE_INT ); |
Collaborator
There was a problem hiding this comment.
A validation check should be added for comment & the lesson_id.
Collaborator
Author
There was a problem hiding this comment.
This function also used for load more in legacy mode. Cannot early return if comment and lesson_id not found.
shewa12
reviewed
Jan 29, 2026
shewa12
reviewed
Jan 29, 2026
shewa12
reviewed
Jan 29, 2026
shewa12
reviewed
Jan 29, 2026
shewa12
reviewed
Jan 29, 2026
Centralized comment and reply DOM ID prefixes and class names into constants to reduce duplication and improve maintainability. Updated all relevant DOM queries and element ID constructions to use these constants.
Adds logic to ensure the toast container is appended to the fullscreen element when the document enters fullscreen mode. This ensures toast notifications remain visible and correctly positioned during fullscreen transitions.
Introduce on_change and bind_active_value support to DropdownFilter. Adds protected properties ($on_change, $active_value) and fluent setters (on_change(), bind_active_value()). Integrates Alpine.js state into x-data to expose labels and counts, binds button label and count to Alpine variables when active_value is set, and conditionally renders option items as buttons that invoke the provided JS callback (or falls back to anchor links). Preserves existing search and count behavior while enabling reactive UI updates via Alpine and a JS change callback.
Replace buffered PHP template with string construction using sprintf. Subtitle is now conditionally built into $subtitle_html, attributes are injected via get_attributes_string(), and the resulting markup is stored in $this->component_string and returned. This simplifies rendering and removes reliance on output buffering while preserving escaping for title and subtitle.
Add editingId and replyingId to the lesson comments state and reset them after successful edit/reply. Rename typo'd handelEditComment to handleEditComment. Update comment template to replace showEditForm/showReplyForm with editingId/replyingId checks, adjust x-show/x-cloak and cancel handlers to clear IDs, and dispatch focus events when opening forms. These changes centralize which comment is being edited or replied to and fix form visibility/behavior and focus handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.