Add a release-gated package smoke test#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem & Solution Overview
Adds a release-gated package smoke test for the published artifact: run
npm pack, install the tarball into a temp dir, use that installed CLI to generate Node and Express apps, install each app's deps, start the server, and assert an HTTP 200 response. It is kept out of the fast default suite (run vianpm run test:package) and executed by arelease.ymlCI workflow on version tags, so it gates every npm release.Testing Done
npm run test:package: 2 passing — Express returns 200 withWelcome to ServerGen!, Node returns 200 withHello World, both booted from the installed tarball, no orphaned processes.npm test(default suite) unchanged at 203.