Skip to content

Checking out the diff between master and idio master#2

Open
tgalery wants to merge 59 commits into
masterfrom
idio-master
Open

Checking out the diff between master and idio master#2
tgalery wants to merge 59 commits into
masterfrom
idio-master

Conversation

@tgalery

@tgalery tgalery commented Sep 18, 2015

Copy link
Copy Markdown
Owner

No description provided.

@nmadhire

nmadhire commented Oct 8, 2015

Copy link
Copy Markdown

@tgalery Please let me know if there are any issues. Also one thing to note is, instead of modifying the jwpl code, I copied the code into current directory. Most of the code you can see in dbpedia.spotlight packages.

@tgalery

tgalery commented Oct 9, 2015

Copy link
Copy Markdown
Owner Author

hey @naveenmadhire, actually it would be really nice to speak to you guys about this. Just so you understand, I'm trying to break the things both you and idio did in your respective repos and try to upstream it to diego's repo.

At the moment, I'm breaking down by funcionality. So I kind of extracted changes to the article parser idio did and created a new pr here #3 . There are a few changes in the way you and david did things, so it would be nice to talk, before sending this to him. Also, it would be nice to understand what else needs to be upstreamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants