Skip to content

Various random improvements#380

Merged
texus merged 1 commit into
texus:1.xfrom
jjuhl:various-random-improvements
Jun 8, 2026
Merged

Various random improvements#380
texus merged 1 commit into
texus:1.xfrom
jjuhl:various-random-improvements

Conversation

@jjuhl

@jjuhl jjuhl commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Although volatile is not used much currently (and it shouldn't be)
it's nice to know that it will behave according to the standard (and
like other compilers do).
@jjuhl jjuhl force-pushed the various-random-improvements branch from 761d9cb to 654bce6 Compare June 5, 2026 19:04
@texus

texus commented Jun 8, 2026

Copy link
Copy Markdown
Owner

As far as I can tell, volatile isn't used anywhere. And I don't think I will ever use it in this project. So I don't really think this is needed.

@jjuhl

jjuhl commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

I also don't think it is currently used. I just wanted to add the flag as a "make sure MSVC behaves as much as the other compilers and as standard compliant as possible" safeguard.
Close or merge the PR as you see fit :)

@texus texus merged commit 760c7a3 into texus:1.x Jun 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants