Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/jit_compiler_a64.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ void JitCompilerA64::enableWriting()

void JitCompilerA64::enableExecution()
{
setPagesRX(code, CodeSize + CalcDatasetItemSize);
setPagesRXKeepIcache(code, CodeSize + CalcDatasetItemSize);
}

void JitCompilerA64::enableAll()
Expand Down
16 changes: 16 additions & 0 deletions src/virtual_memory.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,22 @@ void setPagesRX(void* ptr, size_t bytes) {
#endif
}

void setPagesRXKeepIcache(void* ptr, size_t bytes) {
#if defined(USE_PTHREAD_JIT_WP) && defined(MAC_OS_VERSION_11_0) \
&& MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_VERSION_11_0
if (__builtin_available(macOS 11.0, *)) {
/* The A64 JIT already called __builtin___clear_cache on the exact
modified range inside generateProgram. Only toggle write-protect
here; re-flushing the full buffer is redundant and measurably
expensive on Apple Silicon. */
pthread_jit_write_protect_np(1);
return;
}
#endif
char *errfunc;
pageProtect(ptr, bytes, PAGE_EXECUTE_READ, &errfunc);
}

void setPagesRWX(void* ptr, size_t bytes) {
char *errfunc;
pageProtect(ptr, bytes, PAGE_EXECUTE_READWRITE, &errfunc);
Expand Down
1 change: 1 addition & 0 deletions src/virtual_memory.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ extern "C" {
void* allocMemoryPages(size_t);
void setPagesRW(void*, size_t);
void setPagesRX(void*, size_t);
void setPagesRXKeepIcache(void*, size_t);
void setPagesRWX(void*, size_t);
void* allocLargePagesMemory(size_t);
void freePagedMemory(void*, size_t);
Expand Down
Loading