feat: google ces deployment Add missing securitySettings fields to we…#1316
Merged
Conversation
…… (#17566) [upstream:0eb17e0727b490bf2b513d9c66a9244b4fb506ff] Signed-off-by: Modular Magician <magic-modules@google.com>
c9d457c
into
terraform-google-modules:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing securitySettings fields to webWidgetConfig in ces_deployment
This PR adds missing fields to
web_widget_configin thegoogle_ces_deploymentresource to match the REST API, and fixes some discrepancies in existing fields.Documentation
https://docs.cloud.google.com/customer-engagement-ai/conversational-agents/ps/reference/rest/v1/ChannelProfile#ChannelProfile.WebWidgetConfig
Rationale
The
web_widget_configingoogle_ces_deploymenthad limited support compared to the REST API. Specifically,securitySettingsand its sub-fields were missing, which are needed for configuring allowed origins and reCAPTCHA.Technical Details
securitySettingswithenablePublicAccess,enableOriginCheck,allowedOrigins, andenableRecaptchatoDeployment.yaml.channelTypeto include missing values:FIVE9andCONTACT_CENTER_INTEGRATION.modalityto useMODALITY_UNSPECIFIEDand addCHAT_VOICE_AND_VIDEO.themeto useTHEME_UNSPECIFIED.send_empty_value: truefor boolean fields to ensurefalsevalues are propagated to the API.ces_deployment_full.tf.tmplto showcase the new fields.ces_deployment_test.goto include update tests for the new fields, specifically testing toggling from true to false.Verification Results
Derived from GoogleCloudPlatform/magic-modules#17566