Skip to content

fix(ten-334): require exact-match when finding TEN issue by GitHub ref #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marvin-tensorleap wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ten-334): require exact-match when finding TEN issue by GitHub ref #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/plugins/examples/plugin-github-webhook-dispatcher/src/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,11 +219,19 @@ async function findTenIssue(
companyId: string,
githubRef: string,
): Promise<{ id: string; identifier: string } | null> {
const results = await ctx.issues.list({ companyId, q: githubRef, limit: 5 });
// No limit: text search may tokenize the query and return many broad matches;
// we need all candidates so the exact-string filter below can find the right one.
const results = await ctx.issues.list({ companyId, q: githubRef });
if (!results || results.length === 0) return null;
const issue = results[0];
if (!issue) return null;
return { id: issue.id, identifier: issue.identifier ?? issue.id };
// Only accept issues where the ref literally appears in title or description.
const needle = githubRef.toLowerCase();
const exact = results.find(
(issue) =>
(issue.title?.toLowerCase().includes(needle) ?? false) ||
(issue.description?.toLowerCase().includes(needle) ?? false),
);
if (!exact) return null;
return { id: exact.id, identifier: exact.identifier ?? exact.id };
}

// ──────────────────────────────────────────────
Expand Down
Loading