Enhance test_tutorials.py's handling of notebook magics
#937
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version failed to handle `!pip` commands inside if-then conditionals, and also didn't handle `%` magics. This fixes the script to handle those cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of
scripts/test_tutorials.pydid not handle!pipcommands inside if-then conditionals, and also didn't handle%magics. This PR makes some simple changes to the code to make it handle those cases.The original motivation for these changes were to accommodate different notebook instructions for running pip installs. The notebooks have been changed since then, and the specific constructs that led to this PR are not there anymore. However, IMHO these simple changes are worth adding at some point because the need to combine
!with conditionals (as well as use%magics) may arise again in the future. We can save future maintainers the trouble of figuring this out again.