Add _XOPEN_SOURCE_EXTENDED define to allow compiling on OpenBSD.#204
Open
fcambus wants to merge 1 commit intotenox7:masterfrom
Open
Add _XOPEN_SOURCE_EXTENDED define to allow compiling on OpenBSD.#204fcambus wants to merge 1 commit intotenox7:masterfrom
fcambus wants to merge 1 commit intotenox7:masterfrom
Conversation
Collaborator
|
What about NetBSD and DragonFly BSD? Would it make sense to use a test that matches all the BSDs? |
Author
|
I can't test on NetBSD or DragonFlyBSD, but I think testing for the I would suggest to keep this OpenBSD specific for now. |
edgar-bonet
approved these changes
Oct 15, 2025
Collaborator
edgar-bonet
left a comment
edgar-bonet
left a comment
There was a problem hiding this comment.
LGTM.
The CI failures are unrelated to this change. They are fixed by merging this into master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenBSD also needs the _XOPEN_SOURCE_EXTENDED define.