Fix browser back button not working on PipelineRun detail page

[chrism417]

Changes

This fixes #4783.

When a task is selected on the PipelineRun detail page, TaskRunDetails auto-sets the view=logs query param via a useEffect. This was pushing a new history entry each time, creating an infinite back-button loop: pressing back removed the param, which triggered the effect to re-add it.

Fix

• Pass { replace: true } in TaskRunDetails when auto-setting view=logs so it replaces the current history entry instead of pushing a new one
• Update getViewChangeHandler to accept and forward the replace option

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix browser back button not working on PipelineRun detail page

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: chrism417 / name: Chris Mooney (2c8c4f6)

[AlanGreene]

Thanks for the PR @chrism417. The TaskRunDetails change looks good but we need to avoid breaking changes to the PipelineRun component.

[chrism417]

Hi @AlanGreene, I pushed some changes based on your comments above, let me know if the latest push is correct now. Thanks!

[AlanGreene]

Hi Chris, thanks again for the PR. From my local testing it doesn't look like the changes in the PipelineRun component are needed, the change to add replace: true in TaskRunDetails appears to be sufficient to fix the back button behaviour.

Did you identify a particular scenario that required the changes you made in the PipelineRun component? If so, please share some more details about this including a reproducing example if possible so I can better understand the impact.

[chrism417]

Hi Alan,
You're right. The PipelineRun changes aren't needed for the back-button fix. The core issue was the onViewChange('logs') in TaskRunDetails pushing a new history entry. I've pushed the changes up, let me know your thoughts! Thanks again

[AlanGreene]

The change looks good now, thanks Chris 👍

Can you update the PR description to remove references to the PIpelineRun changes and to reflect the current state?

Once that's done we can mark this ready to merge.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [AlanGreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chrism417]

Just updated, let me know. Thank you for taking the time to review it!

[AlanGreene]

/lgtm