Process root element of embedded emails#201
Open
klammbueddel wants to merge 1 commit intotedious:masterfrom
Open
Process root element of embedded emails#201klammbueddel wants to merge 1 commit intotedious:masterfrom
klammbueddel wants to merge 1 commit intotedious:masterfrom
Conversation
An email with an embedded email can have the following structure: 1: "text/plain" 2: "message/rfc822" 2: "multipart/mixed" 2.1: "text/plain" 2.2: "application/octet-stream" 2.3, "application/octet-stream" Before this fix this structure was parsed as 1: "text/plain" 2: "message/rfc822" 2.1: "multipart/mixed" 2.1.1: "text/plain" 2.1.2: "application/octet-stream" 2.1.3, "application/octet-stream" Hence, downloading attachments was not possible due to wrong part identifiers resolves tedious#188, tedious#43
lucasaba
added a commit
to lucasaba/php-pec
that referenced
this pull request
Dec 13, 2017
Tutte le pec sono mail dentro mail. Quindi è fondamentale una gestione corretta dei vari sotto-insiemi. La soluzione è stata già proposta (tedious/Fetch#201) ma il merge non è stato ancora fatto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An email with an embedded email can have the following structure:
1: "text/plain"
2: "message/rfc822"
2: "multipart/mixed"
2.1: "text/plain"
2.2: "application/octet-stream"
2.3, "application/octet-stream"
Before this fix this structure was parsed as
1: "text/plain"
2: "message/rfc822"
2.1: "multipart/mixed"
2.1.1: "text/plain"
2.1.2: "application/octet-stream"
2.1.3, "application/octet-stream"
Hence, downloading attachments was not possible due to wrong part
identifiers
resolves #188, #43