This repository was archived by the owner on Nov 24, 2022. It is now read-only.
Yet another proposed JS reload to the login page#19
Open
DrTrills wants to merge 1 commit into
Open
Conversation
Fixed errors on GCE, probably a good idea to add to the entire project as it will work with any system/config. I found adding /login helped the issues with redirecting as it checks if the user is logged in and will re-direct them accordingly. Cuts down on redirects which is not only bad, but can confuse some browsers when switching from http->https
Member
There was a problem hiding this comment.
why the setTimeout after the window.location.replace? to let Google boot the app?
also why redirecting to eh/login instead of eh/? When someone still has a session he still ends up at the login page or is there something that I'm missing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed errors on GCE, probably a good idea to add to the entire project as it will work with any system/config. I found adding /login helped the issues with redirecting as it checks if the user is logged in and will re-direct them accordingly. Cuts down on redirects which is not only bad, but can confuse some browsers when switching from http->https