Skip to content

integrity: implement integrity storage #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bigbes merged 1 commit into from
Dec 22, 2025
Merged

integrity: implement integrity storage #21

bigbes merged 1 commit into from
Dec 22, 2025

Conversation

@bigbes
Copy link
Collaborator

@bigbes bigbes commented Dec 19, 2025 •
edited
Loading

Implemented basic integrity storage functionality with hash and signature verification for the go-storage library.

Part of TNTP-4191

@bigbes bigbes changed the title integrity: implement basic integrity storage integrity: implement integrity storage Dec 19, 2025
@bigbes bigbes force-pushed the bigbes/TNTP-4191-implement-storage branch from 86a73ed to 2974290 Compare December 19, 2025 11:43
@coveralls
Copy link

coveralls commented Dec 19, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 20429594591

Details

  • 390 of 397 (98.24%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.8%) to 39.181%
Changes Missing Coverage Covered Lines Changed/Added Lines %
integrity/typed.go 158 165 95.76%
Totals Coverage Status
Change from base Build 20335965201: 6.8%
Covered Lines: 1521
Relevant Lines: 3882
💛 - Coveralls

@bigbes bigbes force-pushed the bigbes/TNTP-4191-implement-storage branch 2 times, most recently from 228397a to f6818c1 Compare December 19, 2025 22:51
oleg-jukovec
oleg-jukovec requested changes Dec 19, 2025
View reviewed changes
@oleg-jukovec oleg-jukovec requested a review from elhimov December 19, 2025 22:58
oleg-jukovec
oleg-jukovec requested changes Dec 20, 2025
View reviewed changes
Copy link
Collaborator

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are red.

@bigbes bigbes force-pushed the bigbes/TNTP-4191-implement-storage branch 3 times, most recently from 28905a8 to afb1a75 Compare December 21, 2025 15:55
patapenka-alexey
patapenka-alexey reviewed Dec 22, 2025
View reviewed changes
@bigbes bigbes force-pushed the bigbes/TNTP-4191-implement-storage branch from afb1a75 to 0f445ef Compare December 22, 2025 10:04
@bigbes bigbes force-pushed the bigbes/TNTP-4191-implement-storage branch from 0f445ef to 53544dd Compare December 22, 2025 10:45
patapenka-alexey
patapenka-alexey approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@patapenka-alexey patapenka-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bigbes bigbes merged commit 887f472 into master Dec 22, 2025
14 checks passed
@bigbes bigbes deleted the bigbes/TNTP-4191-implement-storage branch December 22, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

@patapenka-alexey patapenka-alexey patapenka-alexey approved these changes

@elhimov elhimov Awaiting requested review from elhimov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bigbes @coveralls @oleg-jukovec @patapenka-alexey