chore(ci): remove broken Foundry CI#151
Merged
Merged
Conversation
The Foundry CI job has been red on every PR since the codebase grew past the ubuntu-latest runner's 16 GB memory budget. `forge build --sizes` gets OOM-killed (exit 143) during the 352-file via-IR compile around the 20-minute mark — same failure on every commit including the now-merged #149 and #150. Until we have access to a larger runner (or split the compile graph), this job is pure noise: it blocks no merge (PRs are merged over red CI as a matter of course) and surfaces no signal a developer can act on. EIP-170 facet sizes are now enforced via `test/FacetSize.t.sol` (added in #150), which is much cheaper to run and produces a precise overage number on regression. Local `forge test` remains the source of truth for correctness. Restore once we have a runner with enough RAM (or a leaner compile), or replace with a sharded matrix that fits each shard inside 16 GB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Foundry CI job has been red on every PR since the codebase grew past the ubuntu-latest runner's 16 GB memory budget.
forge build --sizesgets OOM-killed (exit 143) during the 352-file via-IR compile around the 20-minute mark — same failure on #149 and #150.Until we have a larger runner (or split the compile graph), this job is pure noise: it blocks nothing (PRs are merged over red CI as a matter of course) and surfaces no signal a developer can act on.
EIP-170 facet sizes are now enforced via
test/FacetSize.t.sol(#150), which is much cheaper to run and produces a precise overage number on regression. Localforge testremains the source of truth for correctness.Test plan