Open
Conversation
tale
requested changes
Mar 24, 2026
Owner
tale
left a comment
There was a problem hiding this comment.
Left a small nit, appreciate the memoization though
Comment on lines
+95
to
+98
| const userOptions = [ | ||
| ...(tagOwnedExists ? [{ value: "tag-owned", label: "Tag-owned" }] : []), | ||
| ...users.map((u) => ({ value: u.id, label: getUserDisplayName(u) })), | ||
| ]; |
Owner
There was a problem hiding this comment.
I see what you're doing here, but I think it's slightly unexpected behavior where the tooltip/user select dropdown shows names, but the URL shows IDs. They should both be the usernames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the basic filters as described in the #506 feature request I made.
Adds four composable filter dimensions to the Machines page on top of the existing text search. All filter state lives in URL search params so filtered views are fully bookmarkable and shareable.
Params:
All optional and composable.
UI:
Screen.Recording.2026-03-21.at.13.15.16.mov
Changes