Cache tailscale binary file#166
Merged
mpminardi merged 4 commits intotailscale:mainfrom Apr 9, 2025
palindrom615:main
Merged
Conversation
Contributor
|
ah yes, I think this is better approach accounting for inputs.sha256sum. I will close my duplicate PR A few notes:
|
Member
|
Thanks for the contribution! As @twelsh-aw mentioned we'll want this to be opt-in for |
…uilds This commit introduces a new `use-cache` input to the Tailscale GitHub Action. When set to `true`, the action will attempt to restore/install Tailscale binaries from a GitHub Actions cache, rather than always downloading or rebuilding them. If the cache is a hit, the download/build steps are skipped, reducing network flakes and speeding up workflows. The default `false` preserves the original behavior, ensuring full backward compatibility.
Contributor
Author
thanks for notes! definitely better to opt-in. I cherry-picked your commit. in macOS part, I added commit hash for a cache key. please take a look! |
mpminardi
reviewed
Apr 6, 2025
…i after installation Co-authored-by: Mario Minardi <mminardi@shaw.ca>
mpminardi
approved these changes
Apr 9, 2025
Member
|
@palindrom615 @twelsh-aw thank you both again for the contributions on this! Will be getting this into a release shortly. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds caching for Tailscale binary downloads to improve workflow performance and reduce bandwidth usage.
Motivation
At our company, we've experienced occasional download failures when our GitHub Actions workflows run on slower network nodes. These intermittent failures disrupt our CI/CD pipelines and require manual intervention. By implementing caching, we can significantly reduce these failures and improve the reliability of our workflows.
Changes:
This change is backward compatible and requires no configuration changes from users.
related issues: #87 #156