Dropdown components (menu, select, combobox, autocomplete)#85
Merged
Conversation
IzumiSy
changed the base branch from
add_primitive_components
to
primitive_components_basic
IzumiSy
changed the title
commit: |
IzumiSy
force-pushed
the
primitive_components_basic
branch
from
675abe2 to
c22722a
Compare
IzumiSy
force-pushed
the
dropdown_components
branch
from
c797986 to
1571f10
Compare
IzumiSy
force-pushed
the
dropdown_components
branch
from
67105b5 to
c85f035
Compare
- Narrow Select renderValue type based on multiple discriminant - Add value/defaultValue props to Autocomplete.Async - Export AsyncFetcher type from public API - Add JSDoc explaining Combobox.Creatable T extends object constraint
Use !== undefined instead of ?? so that value="" is correctly treated as controlled mode.
…rules - Add Pattern D (Standalone) for pre-assembled + Parts components - Clarify Pick<> rule: Root uses Pick<>, leaf sub-components use ComponentProps - Note Pattern D can combine with Pattern C (directory split)
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Document that items are identified as groups by the presence of label and items fields. Consumers should avoid item types whose shape coincidentally matches this structure.
victornguyen
approved these changes
Mar 19, 2026
| } | ||
| ComboboxClear.displayName = "Combobox.Clear"; | ||
|
|
||
| function ComboboxChips({ className, ...props }: React.ComponentProps<typeof BaseCombobox.Chips>) { |
There was a problem hiding this comment.
Missing displayName on ComboboxChips. Every other sub-component in all new files has one?
Contributor
Author
There was a problem hiding this comment.
Added displayName to ComboboxChips, AutocompleteStandalone, and AutocompleteAsyncStandalone — the three components that were missing it.
Commit: 8509cd5
Comment on lines
+246
to
+247
| * Internally filters out `item-press` events so that selecting an item does | ||
| * not trigger a redundant refetch. |
There was a problem hiding this comment.
My review agent thinks this JSDoc comment might be out of sync with the implementation. I don't see any obvious filtering happening?
Contributor
Author
There was a problem hiding this comment.
Good catch — the JSDoc claimed onValueChange "filters out item-press events" but that logic doesn't exist in the Autocomplete useAsync (it was likely copied from the Combobox variant). Simplified the JSDoc to remove the incorrect claim.
Commit: 375c078
… AutocompleteAsyncStandalone
Remove incorrect claim about filtering item-press events, which does not happen in the Autocomplete useAsync implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new dropdown components (Menu, Select, Combobox, Autocomplete) and improve existing component APIs.
New Components
Select.Async.Combobox.Async.Autocomplete.Async.Select, Combobox, and Autocomplete each expose a
.Partsnamespace with low-level sub-components and hooks (useFilter,useAsync,useCreatable) for custom compositions.Other Changes
side/align/sideOffsetinto a singlepositionprop (old props preserved as deprecated for backward compatibility)positionprop