Fix content length proxying#197
Merged
Merged
Conversation
Contributor
|
One change at a time, please - otherwise Content-Length part looks good to me 👍 |
syumai
reviewed
May 4, 2026
| // from JS Request objects, so it will typically be missing for requests | ||
| // that transit through the JS bridge. When the header is absent but a | ||
| // body stream exists, use -1 (unknown) instead of 0 (empty) so that | ||
| // consumers like PocketBase don't skip body parsing. |
Owner
There was a problem hiding this comment.
PocketBase
This specific tool name doesn't seem necessary. Please remove it from the comment.
Contributor
Author
bro @b0ch3nski, cool down. i thought this repo is abandoned and just fired PRs just in case. |
theuargb
force-pushed
the
fix-content-length-proxying
branch
from
856d5a3 to
32f9699
Compare
Contributor
Well, I'm much in favor of this library and using it in some of my projects - I'm trying to follow the development and contribute back to the community with reviews, fixes and improvements that I stumble upon 😺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with outgoing fetch() requests where Content-Length header could not be set therefore remote origin (the one we fetch()-ing to from our worker) rejectes request with 4xx