Skip to content

fix: scroll wallet screens behind top bar with haze blur#892

Open
jvsena42 wants to merge 10 commits intofeat/connection-issues-viewfrom
fix/spending-and-savings-scroll
Open

fix: scroll wallet screens behind top bar with haze blur#892
jvsena42 wants to merge 10 commits intofeat/connection-issues-viewfrom
fix/spending-and-savings-scroll

Conversation

@jvsena42
Copy link
Copy Markdown
Member

@jvsena42 jvsena42 commented Apr 7, 2026

This PR:

  1. Makes the Spending and Savings wallet screen content scroll behind the top bar, matching the iOS scroll behavior
  2. Applies a haze blur effect with a gradient mask to the AppTopBar on both screens
  3. Extracts the top bar gradient as a shared constant reused by HomeScreen, SavingsWalletScreen, and SpendingWalletScreen

Description

The wallet screens previously used a fixed ScreenColumn layout where the AppTopBar sat above a non-scrollable Column. Content could not scroll behind the top bar, and the top bar had no blur effect.

This replaces the ScreenColumn approach with a Box-based layout: the AppTopBar floats as an overlay with hazeEffect + gradient mask + zIndex(1f), and all content (balance, transfer buttons, activity list) is unified into a single LazyColumn that scrolls underneath. A new LazyListScope.activityListGroupedItems() extension inlines activity items directly into the parent LazyColumn, avoiding nested scrollable containers.

Preview

QA Notes

  1. Open Savings wallet screen with a balance and activity
    • Scroll down and verify the activity list and balance header scroll behind the top bar
    • Verify the top bar shows a frosted glass blur effect with a gradient fade
    • Verify the back button and drawer icon remain tappable
savings.webm
  1. Open Spending wallet screen with a balance and activity
    • Same scroll-behind and blur behavior as Savings
    • Verify "Transfer To Savings" button scrolls with content
spending.webm
  1. Open Savings/Spending wallet with no balance and no activity
    • Verify the empty state onboarding view still displays correctly at the bottom
empty-states.webm
  1. Verify HomeScreen top bar blur still works as before (shared gradient constant)
home.webm

@jvsena42 jvsena42 self-assigned this Apr 7, 2026
@jvsena42 jvsena42 added this to the 2.2.0 milestone Apr 7, 2026
@jvsena42 jvsena42 marked this pull request as ready for review April 7, 2026 14:49
@claude

This comment has been minimized.

@jvsena42 jvsena42 requested a review from ovitrif April 7, 2026 16:18
@ovitrif ovitrif modified the milestones: 2.2.0, 2.3.0 Apr 7, 2026
@jvsena42 jvsena42 removed the request for review from ovitrif April 8, 2026 12:15
@claude

This comment has been minimized.

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 8, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants