fix: scroll wallet screens behind top bar with haze blur#892
Open
jvsena42 wants to merge 10 commits intofeat/connection-issues-viewfrom
Open
fix: scroll wallet screens behind top bar with haze blur#892jvsena42 wants to merge 10 commits intofeat/connection-issues-viewfrom
jvsena42 wants to merge 10 commits intofeat/connection-issues-viewfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Description
The wallet screens previously used a fixed
ScreenColumnlayout where theAppTopBarsat above a non-scrollableColumn. Content could not scroll behind the top bar, and the top bar had no blur effect.This replaces the
ScreenColumnapproach with aBox-based layout: theAppTopBarfloats as an overlay withhazeEffect+ gradient mask +zIndex(1f), and all content (balance, transfer buttons, activity list) is unified into a singleLazyColumnthat scrolls underneath. A newLazyListScope.activityListGroupedItems()extension inlines activity items directly into the parentLazyColumn, avoiding nested scrollable containers.Preview
QA Notes
savings.webm
spending.webm
empty-states.webm
home.webm